PR for the 26-01 Part 2 V3.2 Release#575
Draft
sebbader-sap wants to merge 88 commits into
Draft
Conversation
Add the 'ServerNotImplemented' Status Code
…rationShellById Add Parameter "id" and a new Note to PutAssetAdministrationShellById
* add link to GetFileByPath * SerializationFormat: remove mentioning of AML, RDF because not (yet contained) + outlook that enum may be extended in future releases * formatting of table for Submodel Interface * correct link .adoc instead of html * correct formatting of constraint AASa-003 + update links to V3-1 for Part 1 and 2
* add note for the operation GenerateSerializationByIds * Update documentation/IDTA-01002-3/modules/ROOT/pages/specification/interfaces.adoc Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com> --------- Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
…ll-io/aas-specs-api into IDTA-01002-3-2_working
* fix ServiceSpecificationProfileEnum values for 3.0 and 3.1 * remove TREE (#539) * remove v3.2 profile uris --------- Co-authored-by: Martin Stemmer <52048213+Martin187187@users.noreply.github.com>
* fixed grammar * align with secuity spec * update BNF based on security BNF * fixed schema patterns * fix pattern * adjust datetime & time patterns * fixed modelstringpattern in api * align time pattern to api * align time pattern to api * added missing parentheses * fix grammar bugs * fix typo in changelog --------- Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
* remove swaggerhub links * fix link
* fixing ServiceSpecificationProfileEnum entries + adding v3.2 ones * extend example list in OpenAPI and provide a description as well
#542) * change application/asset-administration-shell-package+xml to application/zip+xml * fix review comments
* add proposal for an async aasx profile * correct result of the get .../results/... endpoint * add missing appearances of the async aasx file server operations
* Create signatures.adoc * Update signatures.adoc * Update signatures.adoc * Signature description * Add JWS * Add operations for JWS signatures * Add JWS signature profiles * Add mapping of JWS signature * Add signature profiles * add changelog for PR Signing (#561) * Add V3.1.2 Bugfixes into V3.2.0 (#541) * fix ServiceSpecificationProfileEnum values for 3.0 and 3.1 * remove TREE (#539) * remove v3.2 profile uris --------- Co-authored-by: Martin Stemmer <52048213+Martin187187@users.noreply.github.com> * remove GetAllAssetAdministrationShellDescriptorsByAssetType from openapi (#530) * added changelog for new signing operations and profiles * undo changes to the profiles table * fix typo --------- Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com> Co-authored-by: Martin Stemmer <52048213+Martin187187@users.noreply.github.com> * adding signature profiles as openapi yaml * editorial fix * editorial change * fix typo --------- Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com> Co-authored-by: aorzelskiGH <48956800+aorzelskiGH@users.noreply.github.com> Co-authored-by: Martin Stemmer <52048213+Martin187187@users.noreply.github.com>
* Create signatures.adoc * Update signatures.adoc * Update signatures.adoc * Signature description * Add JWS * Add operations for JWS signatures * Add JWS signature profiles * Add mapping of JWS signature * Add signature profiles * Apply suggestion from @BirgitBoss * Apply suggestion from @BirgitBoss * Apply suggestion from @BirgitBoss * Apply suggestion from @BirgitBoss --------- Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com> Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
Changelog fix Formatting and Redundancy
…fix structure of payload data types
Correct endpointProtocolVersion values in the example
Annex DPP: fix nav.adoc + update text
* Fixes PUT /shells/{aasIdentifier}/submodels/{submodelIdentifier} return type on 201 status
* Fix response payload type for PutSubmodelById: status code 201 now returns a Submodel instead of a Reference
* Corrects changelog
* Fixes wrong version
* Fix response contracts in Discovery OpenAPI files
Remove status codes 404 and 409 for POST /lookup/shells/{aasIdentifier} to align with create-or-replace and replace/update semantics.
* Corrects changelog
* Adds missing empty line in changelog
---------
Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
#619) * Removes wrong 404 status code for getAllSubmodelDescriptors * Fixes changelog --------- Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
Introduce a new annex that defines a structured, informative set of acceptance tests for conforming implementations. The corpus covers: - Query Language parsing and evaluation - HTTP/REST API (auth, PUT CREATE/UPDATE, invoke, files, query) - Error handling and edge cases (parse, schema, cast errors, profile applicability) Each test case has a stable ID, one-line purpose and expected behaviour, so the corpus can be turned directly into an executable conformance test suite. Aligned with the matching corpus in IDTA-01004. Refs: Review Finding T-16 Made-with: Cursor
…589) Add a normative subsection "Single source of truth for the formula grammar and JSON Schema" to the Query Language chapter. This clarifies that all formula productions (logical expressions, comparisons, FieldIdentifiers, value literals, type casts, $match/$and/$or/$not) are defined here and MUST NOT be redefined or diverged from in IDTA-01004 (Security). This matches the long-standing practical situation where the two specs ship the same BNF fragments and JSON Schema blocks but did not explicitly name one of them as the authoritative source. Refs: Review Finding T-01 Made-with: Cursor
Fix several prose inconsistencies in query-language.adoc that contradict
the BNF grammar and modelStringPattern:
- Cast operator table
Removed duplicate $dateTime row and dropped the stray "$" prefix
from all entries (str, num, bool, hex, dateTime, time). The BNF
defines these as "str"/"num"/"hex"/"bool"/"dateTime"/"time"
without a $ prefix.
- $aas#submodels field table
Added the mandatory [<index>] segment to submodels so the
examples match the BNF production
"submodels" ( "[" [0-9]* "]" ) "." <ReferenceClause>
and the schema modelStringPattern.
- $aasdesc#submodelDescriptors field table
Same fix: added [<index>] to the submodelDescriptors prefix in
all rows (semanticId, supplementalSemanticIds, id, idShort,
endpoints).
- Comparison examples
Updated $aas#submodels references in the comparison-result
tables to $aas#submodels[] so they stay valid against the
tightened regex.
- idShort example
Corrected example "$aas#id" for the idShort row to "$aas#idShort".
- Limitations bullet
Expanded the list of fields available on SubmodelElements to
match the BNF (semanticId, supplementalSemanticIds, idShort,
value, valueType, language).
No BNF or schema changes.
Refs: Review Finding T-11
Made-with: Cursor
…584) Add a normative summary of which Query / Access-Rule FieldIdentifier prefix is meaningful per service specification family (Repository vs. Registry vs. AAS/Submodel service). The table makes it explicit that - $aasdesc / $smdesc are only applicable in Registry deployments; - $cd is only applicable in the ConceptDescriptionRepository family; - queries / access rules referencing a non-applicable prefix in the chosen profile are treated as "not applicable" rather than as evaluation errors. Refs: Review Finding T-07 Made-with: Cursor
* docs(query-language): add normative "Query Evaluation Semantics" Specify how AAS queries MUST be evaluated, covering: - parse and schema validation (400 / 422 mapping), - behaviour of FieldIdentifiers that do not resolve on the target (candidate excluded, no error), - behaviour under profile restrictions (non-applicable prefix is treated like "field not present"), - semantics of list-valued FieldIdentifiers (existential match), - behaviour on casting errors (candidate excluded, query stays green), - interaction with Access Rules (IDTA-01004): applicable ALLOW rules filter the candidate set; "not applicable" rules do not fail the query. Refs: Review Finding T-15 Made-with: Cursor * fix local reference --------- Co-authored-by: sebbader-sap <107036549+sebbader-sap@users.noreply.github.com>
Add a NOTE next to the FieldIdentifier root-element table that explicitly maps each $-prefix to the corresponding Metamodel class (IDTA-01001) and API resource path. References the new normative terminology matrix in IDTA-01001 as the single source of truth and states that prefixes are lower-case only. Refs: Review Finding T-09 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.